Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) add UT case "diagonal with zero diagonal element" #172

Merged
merged 2 commits into from
Jun 10, 2023
Merged

(test) add UT case "diagonal with zero diagonal element" #172

merged 2 commits into from
Jun 10, 2023

Conversation

ThibFrgsGmz
Copy link
Contributor

This PR adds one test case to is_diagonal test suite where we have a diagonal with on zero/null element.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.02 🎉

Comparison is base (2ee5225) 66.33% compared to head (a3b81a1) 66.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   66.33%   66.36%   +0.02%     
==========================================
  Files         127      127              
  Lines       32445    32456      +11     
==========================================
+ Hits        21524    21538      +14     
+ Misses      10921    10918       -3     
Impacted Files Coverage Δ
src/utils.rs 52.68% <66.66%> (+1.28%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopherRabotin ChristopherRabotin merged commit 7de0b3a into nyx-space:master Jun 10, 2023
@ThibFrgsGmz ThibFrgsGmz deleted the test/improve_is_diag_test branch June 11, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants